[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 23/24] qcow2: Relax is_zero() assertion
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 23/24] qcow2: Relax is_zero() assertion |
Date: |
Fri, 20 Oct 2017 10:32:52 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/20/2017 10:11 AM, Kevin Wolf wrote:
> Am 12.10.2017 um 15:20 hat Eric Blake geschrieben:
>> On 10/11/2017 10:47 PM, Eric Blake wrote:
>>> Now that bdrv_is_allocated accepts non-aligned inputs, we can
>>> remove the TODO added in earlier refactoring.
>>>
>>> Signed-off-by: Eric Blake <address@hidden>
>>
>> I was a bit too hasty in the copy-and-paste from 22/24 - there is no
>> assertion in this patch, so the subject would be better as:
>>
>> qcow2: Reduce is_zero() rounding
>
> In fact, I don't see any assertion being modified in patch 22 either.
Oh, indeed. Not sure what I was thinking; I guess it's because I added
22 at the same time I added several other TODO assertions to series 1 a
couple months ago, with the plans to relax rounding/assertions as
appropriate later in the series, and then got confused on which things
were being relaxed where ;)
If it's just the subject lines for 22 and 23 that need fixing, I trust
you can do that as maintainer.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 17/24] qemu-img: Change check_empty_sectors() to byte-based, (continued)
- [Qemu-devel] [PATCH v6 17/24] qemu-img: Change check_empty_sectors() to byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 16/24] qemu-img: Drop redundant error message in compare, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 18/24] qemu-img: Change compare_sectors() to be byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 19/24] qemu-img: Change img_rebase() to be byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 20/24] qemu-img: Change img_compare() to be byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 22/24] block: Relax bdrv_aligned_preadv() assertion, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 21/24] block: Align block status requests, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 23/24] qcow2: Relax is_zero() assertion, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 24/24] qemu-io: Relax 'alloc' now that block-status doesn't assert, Eric Blake, 2017/10/11
- Re: [Qemu-devel] [PATCH v6 00/24] make bdrv_get_block_status byte-based, Kevin Wolf, 2017/10/20