[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] ide: avoid referencing NULL dev in rotational rate
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PATCH] ide: avoid referencing NULL dev in rotational rate setting |
Date: |
Fri, 20 Oct 2017 10:14:03 +0100 |
The 'dev' variable can be NULL when the guest OS calls identify on an IDE
unit that does not have a drive attached to it.
Signed-off-by: Daniel P. Berrange <address@hidden>
---
hw/ide/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index a04766aee7..471d0c928b 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -208,7 +208,9 @@ static void ide_identify(IDEState *s)
if (dev && dev->conf.discard_granularity) {
put_le16(p + 169, 1); /* TRIM support */
}
- put_le16(p + 217, dev->rotation_rate); /* Nominal media rotation rate */
+ if (dev) {
+ put_le16(p + 217, dev->rotation_rate); /* Nominal media rotation rate
*/
+ }
ide_identify_size(s);
s->identify_set = 1;
--
2.13.6
- [Qemu-devel] [PATCH] ide: avoid referencing NULL dev in rotational rate setting,
Daniel P. Berrange <=