[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] x86/cpufeatures: Enable new AVX512 cpu features
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] x86/cpufeatures: Enable new AVX512 cpu features |
Date: |
Wed, 18 Oct 2017 12:32:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 17/10/2017 11:34, Yang Zhong wrote:
> Intel IceLake cpu has added new cpu features,AVX512VBMI2/GFNI/
> VAES/AVX512VNNI/AVX512BITALG/VPCLMULQDQ. Those new cpu features
> need expose to guest VM.
>
> The bit definition:
> CPUID.(EAX=7,ECX=0):ECX[bit 06] AVX512VBMI2
> CPUID.(EAX=7,ECX=0):ECX[bit 08] GFNI
> CPUID.(EAX=7,ECX=0):ECX[bit 09] VAES
> CPUID.(EAX=7,ECX=0):ECX[bit 10] VPCLMULQDQ
> CPUID.(EAX=7,ECX=0):ECX[bit 11] AVX512VNNI
> CPUID.(EAX=7,ECX=0):ECX[bit 12] AVX512_BITALG
>
> The release document ref below link:
> https://software.intel.com/sites/default/files/managed/c5/15/
> architecture-instruction-set-extensions-programming-reference.pdf
>
> Signed-off-by: Yang Zhong <address@hidden>
Have you sent the KVM part of this too? I cannot find it.
Paolo
> ---
> target/i386/cpu.c | 6 +++---
> target/i386/cpu.h | 6 ++++++
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 98732cd..03fb8ad 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -435,9 +435,9 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] =
> {
> [FEAT_7_0_ECX] = {
> .feat_names = {
> NULL, "avx512vbmi", "umip", "pku",
> - "ospke", NULL, NULL, NULL,
> - NULL, NULL, NULL, NULL,
> - NULL, NULL, "avx512-vpopcntdq", NULL,
> + "ospke", NULL, "avx512vbmi2", NULL,
> + "gfni", "vaes", "vpclmulqdq", "avx512vnni",
> + "avx512bitalg", NULL, "avx512-vpopcntdq", NULL,
> "la57", NULL, NULL, NULL,
> NULL, NULL, "rdpid", NULL,
> NULL, NULL, NULL, NULL,
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index b086b15..cdbf8b0 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -635,6 +635,12 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
> #define CPUID_7_0_ECX_UMIP (1U << 2)
> #define CPUID_7_0_ECX_PKU (1U << 3)
> #define CPUID_7_0_ECX_OSPKE (1U << 4)
> +#define CPUID_7_0_ECX_VBMI2 (1U << 6) /* Additional VBMI Instrs */
> +#define CPUID_7_0_ECX_GFNI (1U << 8)
> +#define CPUID_7_0_ECX_VAES (1U << 9)
> +#define CPUID_7_0_ECX_VPCLMULQDQ (1U << 10)
> +#define CPUID_7_0_ECX_AVX512VNNI (1U << 11)
> +#define CPUID_7_0_ECX_AVX512BITALG (1U << 12)
> #define CPUID_7_0_ECX_AVX512_VPOPCNTDQ (1U << 14) /* POPCNT for vectors of
> DW/QW */
> #define CPUID_7_0_ECX_LA57 (1U << 16)
> #define CPUID_7_0_ECX_RDPID (1U << 22)
>