[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MT
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values |
Date: |
Mon, 16 Oct 2017 14:26:27 +0100 |
On 16 October 2017 at 14:09, Laurent Vivier <address@hidden> wrote:
> For this part, yes, but I think for the other comment, STRUCT(mtget,
> ...) needs to be updated.
Looking more closely I don't think it is as simple as just
adjusting the STRUCT() definition. For a basic type that can
be different on host and guest, I think we'd need to handle
it the way we do the TYPE_OLDDEVT, with special support
in the thunk code for figuring out how large it is and so on.
That seems like a lot of work for a magtape ioctl that I
suspect nobody's using and which we can't test...
Applying this patch as-is would at least fix the ioctl
for everything except MIPS and SPARC hosts and guests.
thanks
-- PMM
- [Qemu-devel] [PATCH 0/2] fix incorrect target ioctl numbers, Peter Maydell, 2017/10/12
- [Qemu-devel] [PATCH 1/2] linux-user: Fix target FS_IOC_GETFLAGS and FS_IOC_SETFLAGS numbers, Peter Maydell, 2017/10/12
- [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values, Peter Maydell, 2017/10/12
- Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values, Laurent Vivier, 2017/10/12
- Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values, Peter Maydell, 2017/10/12
- Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values, Laurent Vivier, 2017/10/12
- Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values, Riku Voipio, 2017/10/16
- Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values, Laurent Vivier, 2017/10/16
- Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values, Laurent Vivier, 2017/10/16