[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/8] nbd: Expose constants and structs for st
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/8] nbd: Expose constants and structs for structured read |
Date: |
Mon, 16 Oct 2017 07:15:03 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/16/2017 03:49 AM, Vladimir Sementsov-Ogievskiy wrote:
> 15.10.2017 04:01, Eric Blake wrote:
>> Upcoming patches will implement the NBD structured reply
>> extension [1] for both client and server roles. Declare the
>> constants, structs, and lookup routines that will be valuable
>> whether the server or client code is backported in isolation.
>>
>> This includes moving one constant from an internal header to
>> the public header, as part of the structured read processing
>> will be done in block/nbd-client.c rather than nbd/client.c.
>>
>> [1]https://github.com/NetworkBlockDevice/nbd/blob/extension-structured-reply/doc/proto.md
>>
>
> this link may become dead in future, after merging extension spec into
> master...
Perhaps; but it's a git branch, so it's not going to disappear, even
when it is no longer actively maintained. For comparison, here's the
(now-stale) link for NBD_CMD_WRITE_ZEROES:
https://github.com/NetworkBlockDevice/nbd/blob/extension-write-zeroes/doc/proto.md
So I'm not too worried about having the URL in the commit message.
>
>>
>> Based on patches from Vladimir Sementsov-Ogievskiy.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 0/8] nbd mimimal structured read, Eric Blake, 2017/10/14
- [Qemu-devel] [PATCH v4 1/8] nbd: Include error names in trace messages, Eric Blake, 2017/10/14
- [Qemu-devel] [PATCH v4 2/8] nbd: Move nbd_errno_to_system_errno() to public header, Eric Blake, 2017/10/14
- [Qemu-devel] [PATCH v4 3/8] nbd: Expose constants and structs for structured read, Eric Blake, 2017/10/14
- [Qemu-devel] [PATCH v4 4/8] nbd: Minimal structured read for server, Eric Blake, 2017/10/14
- Re: [Qemu-devel] [PATCH v4 4/8] nbd: Minimal structured read for server, Eric Blake, 2017/10/16
- [Qemu-devel] [PATCH v4 8/8] nbd: Move nbd_read() to common header, Eric Blake, 2017/10/14
- [Qemu-devel] [PATCH v4 5/8] nbd/server: Include human-readable message in structured errors, Eric Blake, 2017/10/14