[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test |
Date: |
Mon, 16 Oct 2017 13:09:02 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Juan Quintela (address@hidden) wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> tests/migration-test.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index cd954caee4..8ef2b72459 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -466,6 +466,13 @@ static void test_precopy_unix(void)
> g_free(uri);
> }
>
> +static void test_precopy_tcp(void)
> +{
> + const char *uri = "tcp:0:44444";
> +
> + test_precopy(uri);
> +}
The problem is that this will fail if you make check -j and two
tests use 4444 at the same time.
That's pretty common especially when you've built multiple architectures
as targets and all the same tests run at the same time.
Dave
> int main(int argc, char **argv)
> {
> char template[] = "/tmp/migration-test-XXXXXX";
> @@ -482,6 +489,7 @@ int main(int argc, char **argv)
> module_call_init(MODULE_INIT_QOM);
>
> qtest_add_func("/migration/precopy/unix", test_precopy_unix);
> + qtest_add_func("/migration/precopy/tcp", test_precopy_tcp);
>
> ret = g_test_run();
>
> --
> 2.13.5
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 0/6] Add make check tests for Migration, Juan Quintela, 2017/10/04
- [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test, Juan Quintela, 2017/10/04
- Re: [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 3/6] tests: Add precopy test using deprecated commands, Juan Quintela, 2017/10/04
- [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Juan Quintela, 2017/10/04
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Eric Blake, 2017/10/04
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, Peter Xu, 2017/10/09