[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/11] gtk: fix wrong id between texture and framebuf
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 11/11] gtk: fix wrong id between texture and framebuffer |
Date: |
Fri, 13 Oct 2017 10:14:50 +0200 |
From: Anthoine Bourgeois <address@hidden>
The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."
Signed-off-by: Anthoine Bourgeois <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/gtk-gl-area.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 01ebf2c7de..7080f4e14f 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
- if (vc->gfx.guest_fb.framebuffer == 0 ||
- vc->gfx.w == 0 || vc->gfx.h == 0) {
+ if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
gtk_gl_area_set_scanout_mode(vc, false);
return;
}
--
2.9.3
- [Qemu-devel] [PULL 00/11] Ui 20171013 patches, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 08/11] Add pc-bios/keymaps/Makefile, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 06/11] ui: don't export qemu_input_event_new_key, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 05/11] ui: convert key events to QKeyCodes immediately, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 11/11] gtk: fix wrong id between texture and framebuffer,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 03/11] ui: add keycodemapdb repository as a GIT submodule, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 02/11] docker: don't rely on submodules existing in the main checkout, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 01/11] build: automatically handle GIT submodule checkout for dtc, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 07/11] tools: add qemu-keymap, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 04/11] ui: convert common input code to keycodemapdb, Gerd Hoffmann, 2017/10/13
- [Qemu-devel] [PULL 10/11] ui/gtk: Fix deprecation of vte_terminal_copy_clipboard, Gerd Hoffmann, 2017/10/13
- Re: [Qemu-devel] [PULL 00/11] Ui 20171013 patches, Daniel P. Berrange, 2017/10/13
- [Qemu-devel] [PULL 09/11] pc-bios/keymaps: keymaps update, Gerd Hoffmann, 2017/10/13