[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] oslib-posix: Fix compiler warning
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] oslib-posix: Fix compiler warning |
|
Date: |
Tue, 10 Oct 2017 10:17:11 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/10/2017 09:48 AM, Stefan Weil wrote:
> If we really expect more than 2^32 pages, touching all those pages
> will need a significant time even on fast machines.
Sure. But surely taking a long time is better than silently ignoring high-bits
of a quantity.
> What about using size_t instead of uint64_t? Parts of the code already
> use size_t, and it makes a difference for QEMU running on 32 bit hosts.
I'm ok with that, so long as all of the relevant variables are changed, not
just that of "i".
r~