qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] build: remove CONFIG_LIBDECNUMBER


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] build: remove CONFIG_LIBDECNUMBER
Date: Tue, 10 Oct 2017 09:39:46 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 10/10/2017 07:57 AM, Paolo Bonzini wrote:
> On 10/10/2017 16:47, Richard Henderson wrote:
>> On 10/10/2017 03:26 AM, Paolo Bonzini wrote:
>>> It is used only by PPC TCG, so just move it in target/ppc/Makefile.objs
>>>
>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>
>> FWIW, it *should* be used by target/s390x as well.
>>
>>> diff --git a/target/ppc/Makefile.objs b/target/ppc/Makefile.objs
>>> index f92ba67ebd..ba61012bef 100644
>>> --- a/target/ppc/Makefile.objs
>>> +++ b/target/ppc/Makefile.objs
>>> @@ -15,5 +15,10 @@ obj-y += int_helper.o
>>>  obj-y += timebase_helper.o
>>>  obj-y += misc_helper.o
>>>  obj-y += mem_helper.o
>>> +obj-y += ../../libdecnumber/decContext.o
>>> +obj-y += ../../libdecnumber/decNumber.o
>>> +obj-y += ../../libdecnumber/dpd/decimal32.o
>>> +obj-y += ../../libdecnumber/dpd/decimal64.o
>>> +obj-y += ../../libdecnumber/dpd/decimal128.o
>>>  obj-$(CONFIG_USER_ONLY) += user_only_helper.o
>>>  obj-y += gdbstub.o
>>
>> I suppose this isn't horrible, if it needed to be replicated.
> 
> If it has to be replicated, it should be
> 
> obj-y += ../../libdecnumber/
> 
> I'll post v2.

I think I wasn't clear -- s390x does not yet use libdecnumber because we
haven't written the emulation instructions.  But we should do.  It shouldn't
even be particularly hard, since all of the heavy lifting is in the library 
itself.

So no need to add anything at the moment; you've simply answered my question
about what *should* happen.


r~

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]