[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 11/43] tcg: define CF_PARALLEL and use it for
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v4 11/43] tcg: define CF_PARALLEL and use it for TB hashing along with CF_COUNT_MASK |
Date: |
Mon, 9 Oct 2017 18:23:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/09/2017 12:24 PM, Emilio G. Cota wrote:
> On Thu, Oct 05, 2017 at 19:24:16 -0400, Emilio G. Cota wrote:
>> I'm including the fixups below.
>
> Just pushed v5 of this series. I rebased the series on top of the current
> master,
> and added the already mentioned fixes plus a new one (see below).
>
> Grab the patches from:
> https://github.com/cota/qemu/tree/multi-tcg-v5
Thanks. I was just about to do this rebase myself.
> Changes since v4:
> - Rebase to current master. (fixed a few conflicts, mostly due to some targets
> having been converted to the generic translation loop.)
> - Add the removal of CF_COUNT_MASK as a separate "FIXUP" commit to signal
> that this still requires attention.
> - Fix tb TC comparison function to support deletions (otherwise -icount
> breaks)
> - [new fix] TCG regions: Rely on max_cpus instead of smp_cpus. Otherwise we'd
> break CPU hotplug on targets that support it. (max_cpus and smp_cpus are
> set from the command line with -smp foo,maxcpus=bar; max_cpus is always
> >= smp_cpus.)
Excellent. I'll work on reviewing these changes this week.
In the meantime, I've cherry-picked about half of the patch set.
r~