[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 17/23] tcg: take .helpers out of TCGContext
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 17/23] tcg: take .helpers out of TCGContext |
Date: |
Mon, 9 Oct 2017 17:55:54 -0700 |
From: "Emilio G. Cota" <address@hidden>
Groundwork for supporting multiple TCG contexts.
The hash table becomes read-only after it is filled in,
so we can save space by keeping just a global pointer to it.
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/tcg.h | 2 --
tcg/tcg.c | 10 +++++-----
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/tcg/tcg.h b/tcg/tcg.h
index 25662c36d4..b2d42e3136 100644
--- a/tcg/tcg.h
+++ b/tcg/tcg.h
@@ -656,8 +656,6 @@ struct TCGContext {
tcg_insn_unit *code_ptr;
- GHashTable *helpers;
-
#ifdef CONFIG_PROFILER
/* profiling info */
int64_t tb_count1;
diff --git a/tcg/tcg.c b/tcg/tcg.c
index a874bdd41f..ee60798438 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -318,6 +318,7 @@ typedef struct TCGHelperInfo {
static const TCGHelperInfo all_helpers[] = {
#include "exec/helper-tcg.h"
};
+static GHashTable *helper_table;
static int indirect_reg_alloc_order[ARRAY_SIZE(tcg_target_reg_alloc_order)];
static void process_op_defs(TCGContext *s);
@@ -328,7 +329,6 @@ void tcg_context_init(TCGContext *s)
TCGOpDef *def;
TCGArgConstraint *args_ct;
int *sorted_args;
- GHashTable *helper_table;
memset(s, 0, sizeof(*s));
s->nb_globals = 0;
@@ -356,7 +356,7 @@ void tcg_context_init(TCGContext *s)
/* Register helpers. */
/* Use g_direct_hash/equal for direct pointer comparisons on func. */
- s->helpers = helper_table = g_hash_table_new(NULL, NULL);
+ helper_table = g_hash_table_new(NULL, NULL);
for (i = 0; i < ARRAY_SIZE(all_helpers); ++i) {
g_hash_table_insert(helper_table, (gpointer)all_helpers[i].func,
@@ -982,7 +982,7 @@ void tcg_gen_callN(TCGContext *s, void *func, TCGArg ret,
unsigned sizemask, flags;
TCGHelperInfo *info;
- info = g_hash_table_lookup(s->helpers, (gpointer)func);
+ info = g_hash_table_lookup(helper_table, (gpointer)func);
flags = info->flags;
sizemask = info->sizemask;
@@ -1211,8 +1211,8 @@ static char *tcg_get_arg_str_idx(TCGContext *s, char *buf,
static inline const char *tcg_find_helper(TCGContext *s, uintptr_t val)
{
const char *ret = NULL;
- if (s->helpers) {
- TCGHelperInfo *info = g_hash_table_lookup(s->helpers, (gpointer)val);
+ if (helper_table) {
+ TCGHelperInfo *info = g_hash_table_lookup(helper_table, (gpointer)val);
if (info) {
ret = info->name;
}
--
2.13.6
- [Qemu-devel] [PULL 05/23] cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find, (continued)
- [Qemu-devel] [PULL 05/23] cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 06/23] tcg/i386: constify tcg_target_callee_save_regs, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 08/23] tcg: remove addr argument from lookup_tb_ptr, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 07/23] tcg/mips: constify tcg_target_callee_save_regs, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 09/23] tcg: consolidate TB lookups in tb_lookup__cpu_state, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 10/23] exec-all: bring tb->invalid into tb->cflags, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 12/23] exec-all: introduce TB_PAGE_ADDR_FMT, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 11/23] translate-all: define and use DEBUG_TB_FLUSH_GATE, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 13/23] translate-all: define and use DEBUG_TB_INVALIDATE_GATE, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 15/23] exec-all: extract tb->tc_* into a separate struct tc_tb, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 17/23] tcg: take .helpers out of TCGContext,
Richard Henderson <=
- [Qemu-devel] [PULL 14/23] translate-all: define and use DEBUG_TB_CHECK_GATE, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 19/23] util: move qemu_real_host_page_size/mask to osdep.h, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 16/23] tci: move tci_regs to tcg_qemu_tb_exec's stack, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 20/23] osdep: introduce qemu_mprotect_rwx/none, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 21/23] translate-all: use qemu_protect_rwx/none helpers, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 18/23] tcg: allocate optimizer temps with tcg_malloc, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 22/23] tcg: define TCG_HIGHWATER, Richard Henderson, 2017/10/09
- [Qemu-devel] [PULL 23/23] tcg/mips: delete commented out extern keyword., Richard Henderson, 2017/10/09
- Re: [Qemu-devel] [PULL 00/23] Queued TCG patches, no-reply, 2017/10/09
- Re: [Qemu-devel] [PULL 00/23] Queued TCG patches, no-reply, 2017/10/09