Re: [Qemu-devel] [PULL 3/5] hmp-commands-info: Fix "info rocker-FOO" misspellings

[Dr. David Alan Gilbert]

* Paolo Bonzini (address@hidden) wrote:
> On 05/10/2017 12:51, Dr. David Alan Gilbert (git) wrote:
> > From: Markus Armbruster <address@hidden>
> > 
> > Screwed up in commit da76ee7.
> 
> Let me introduce you to these two aliases:
> 
>         whatis = "show -s --pretty='tformat:%h (\"%s\", %cd)' --date=short"
>         pwhatis = "show -s --pretty='tformat:%h, \"%s\", %cd' --date=short"
> 
> $ git whatis da76ee7
> da76ee76f7 ("hmp-commands-info: move info_cmds content out of monitor.c", 
> 2015-09-16)
> 
> pwhatis is more appropriate if you are including the commit at the end
> of a parenthetical remark, like
> 
>    ... (see commit message for 53ec73e, "block: Use bdrv_drain to
>    replace uncessary bdrv_drain_all", 2015-07-07).

Ah well, that was just Markus's message; personally I'd
uses a 
Fixes: da76ee7

then we've got a chance of automation.

Dave

> Paolo
> 
> > Signed-off-by: Markus Armbruster <address@hidden>
> > Message-Id: <address@hidden>
> > Reviewed-by: Marc-André Lureau <address@hidden>
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK