[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] qom: introduce type_register_static_arra
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] qom: introduce type_register_static_array() |
Date: |
Thu, 5 Oct 2017 09:36:28 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/04/2017 07:08 AM, Igor Mammedov wrote:
> it will help to remove code duplication of registration
> static types in places that have open coded loop to
> perform batch type registering.
>
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/qom/object.h | 10 ++++++++++
> qom/object.c | 9 +++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 76a5e3a..ce25567 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -789,6 +789,16 @@ Type type_register_static(const TypeInfo *info);
> Type type_register(const TypeInfo *info);
>
> /**
> + * type_register_static_array:
> + * @infos: The array of the new type #TypeInfo structures.
> + * @nr_infos: number of entries in @infos
> + *
> + * @infos and all of the strings it points to should exist for the life time
> + * that the type is registered.
> + */
> +void type_register_static_array(const TypeInfo *infos, int nr_infos);
> +
> +/**
> * object_class_dynamic_cast_assert:
> * @klass: The #ObjectClass to attempt to cast.
> * @typename: The QOM typename of the class to cast to.
> diff --git a/qom/object.c b/qom/object.c
> index 3e18537..f4c377a 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -151,6 +151,15 @@ TypeImpl *type_register_static(const TypeInfo *info)
> return type_register(info);
> }
>
> +void type_register_static_array(const TypeInfo *infos, int nr_infos)
> +{
> + int i;
> +
> + for (i = 0; i < nr_infos; i++) {
> + type_register_static(&infos[i]);
> + }
> +}
> +
> static TypeImpl *type_get_by_name(const char *name)
> {
> if (name == NULL) {
>
- Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S](), (continued)
- Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S](), Eduardo Habkost, 2017/10/03
- Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S](), Igor Mammedov, 2017/10/03
- Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S](), Eduardo Habkost, 2017/10/03
- Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S](), Igor Mammedov, 2017/10/03
- Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S](), Eduardo Habkost, 2017/10/03
- Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S](), Peter Maydell, 2017/10/03
- Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S](), Igor Mammedov, 2017/10/03
[Qemu-devel] [PATCH v2 0/3] add DEFINE_TYPES() helper to simplify batch type registration, Igor Mammedov, 2017/10/04
[Qemu-devel] [PATCH v2 1/3] qom: update doc comment for type_register[_static](), Igor Mammedov, 2017/10/04
Re: [Qemu-devel] [PATCH v2 1/3] qom: update doc comment for type_register[_static](), Eduardo Habkost, 2017/10/04
[Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES(), Igor Mammedov, 2017/10/04
Re: [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES(), Eduardo Habkost, 2017/10/04
Re: [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES(), Igor Mammedov, 2017/10/05
Re: [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES(), Philippe Mathieu-Daudé, 2017/10/05
[Qemu-devel] [PATCH 02/38] alpha: cleanup cpu type name composition, Igor Mammedov, 2017/10/02
[Qemu-devel] [PATCH 07/38] lm32: milkymist: use generic cpu_model parsing, Igor Mammedov, 2017/10/02