[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Add random ioctls
From: |
Marco A L Barbosa |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Add random ioctls |
Date: |
Thu, 5 Oct 2017 07:24:48 -0300 |
>
> I doesn't look really trivial...
>
> To manage the buf field you must read buf_size and it cannot be done in
> a generic way: you must define a function to translate the buffer, use
> IOCTL_SPECIAL() with RNDADDENTROPY and RNDGETPOOL.
>
> You should send your patch using "git send-email" or "git publish"
> instead of adding it in you email client.
>
Thanks for your advices.
My use case only requires support for RNDGETENTCNT... Considering that
RNDADDENTROPY and RNDGETPOOL are non trivial, would a patch with only
RNDGETENTCNT, RNDADDTOENTCNT, RNDZAPENTCNT and RNDCLEARPOOL be accepted?
Note: I swapped the types of RNDADDTOENTCNT and RNDGETPOOL...