|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client |
Date: | Thu, 5 Oct 2017 12:59:15 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
03.10.2017 17:06, Paolo Bonzini wrote:
On 03/10/2017 15:35, Vladimir Sementsov-Ogievskiy wrote:In the end this probably means that you have a read_chunk_header function and a read_chunk function. READ has a loop that calls read_chunk_header followed by direct reading into the QEMUIOVector, while everyone else calls read_chunk.accordingly to spec, we can receive several error reply chunks to any request, so loop, receiving them should be common for all requests I thinkas well as handling error chunks should be common..Yes, reading error chunks should be part of read_chunk_header. Paolo
-- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |