[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH 20/20] nvic: Add missing code for wri
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH 20/20] nvic: Add missing code for writing SHCSR.HARDFAULTPENDED bit |
Date: |
Thu, 5 Oct 2017 01:33:01 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/22/2017 12:00 PM, Peter Maydell wrote:
> When we added support for the new SHCSR bits in v8M in commit
> 437d59c17e9 the code to support writing to the new HARDFAULTPENDED
> bit was accidentally only added for non-secure writes; the
> secure banked version of the bit should also be writable.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/intc/armv7m_nvic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> index bd1d5d3..22d5e6e 100644
> --- a/hw/intc/armv7m_nvic.c
> +++ b/hw/intc/armv7m_nvic.c
> @@ -1230,6 +1230,7 @@ static void nvic_writel(NVICState *s, uint32_t offset,
> uint32_t value,
if (attrs.secure) {
if banked then arch is v8M,
> s->sec_vectors[ARMV7M_EXCP_BUS].enabled = (value & (1 << 17)) !=
> 0;
> s->sec_vectors[ARMV7M_EXCP_USAGE].enabled =
> (value & (1 << 18)) != 0;
> + s->sec_vectors[ARMV7M_EXCP_HARD].pending = (value & (1 << 21))
> != 0;
therefore this bit is present.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> /* SecureFault not banked, but RAZ/WI to NS */
> s->vectors[ARMV7M_EXCP_SECURE].active = (value & (1 << 4)) != 0;
> s->vectors[ARMV7M_EXCP_SECURE].enabled = (value & (1 << 19)) !=
> 0;
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [Qemu-arm] [PATCH 20/20] nvic: Add missing code for writing SHCSR.HARDFAULTPENDED bit,
Philippe Mathieu-Daudé <=