[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/5] netduino2: Specify the valid CPUs
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v1 2/5] netduino2: Specify the valid CPUs |
Date: |
Wed, 4 Oct 2017 19:21:09 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
>>> +const char *netduino_valid_cpus[] = { ARM_CPU_TYPE_NAME("cortex-m3"),
>> style nit, ^^^ put entries on new line with
>> typical 4 space alignment
>
> Do you mean like this?
>
> const char *netduino_valid_cpus[] = {
> ARM_CPU_TYPE_NAME("cortex-m3"),
> ARM_CPU_TYPE_NAME("cortex-m4"),
> NULL };
I suppose he meant:
static const char *netduino_valid_cpus[] = {
ARM_CPU_TYPE_NAME("cortex-m3"),
ARM_CPU_TYPE_NAME("cortex-m4"),
NULL
};
- [Qemu-devel] [PATCH v1 1/5] machine: Add a valid_cpu_types property, (continued)
[Qemu-devel] [PATCH v1 2/5] netduino2: Specify the valid CPUs, Alistair Francis, 2017/10/03
[Qemu-devel] [PATCH v1 4/5] xilinx_zynq: : Specify the valid CPUs, Alistair Francis, 2017/10/03
[Qemu-devel] [PATCH v1 5/5] raspi: : Specify the valid CPUs, Alistair Francis, 2017/10/03
Message not available