Re: [Qemu-devel] [PATCH 02/11] qapi: Stop rejecting #optional

[Marc-André Lureau]

On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster <address@hidden> wrote:
> Commit 1d8bda1 got rid of #optional tags, and added a check to keep
> them from getting added back, to make sure patches then in flight
> don't add them back.  It's been six months, time to drop that check.
>
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  scripts/qapi.py | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 62dc52ed6e..dc92bca620 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -234,10 +234,6 @@ class QAPIDoc(object):
>              raise QAPIParseError(self.parser,
>                                   "'%s' not allowed in free-form 
> documentation"
>                                   % match.group(1))
> -        # TODO Drop this once the dust has settled
> -        if (isinstance(self.section, QAPIDoc.ArgSection)
> -                and '#optional' in line):
> -            raise QAPISemError(self.info, "Please drop the #optional tag")
>          self.section.append(line)
>
>      def connect_member(self, member):
> --
> 2.13.6
>
>



-- 
Marc-André Lureau