[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug via dev
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug via device_add |
|
Date: |
Wed, 4 Oct 2017 10:05:35 +0200 |
On Mon, 02 Oct 2017 09:47:58 +0200
Markus Armbruster <address@hidden> wrote:
> Cornelia Huck <address@hidden> writes:
>
> > On Wed, 13 Sep 2017 15:23:55 +0200
> > David Hildenbrand <address@hidden> wrote:
> >
> >> The first patches are a bunch of cleanups. I decided to go the
> >> extra mile and implement CPU hotplug via "device_add", as well as
> >> "query-hotpluggable-cpus".
> >>
> >> On s390x, only complete cores can be plugged. CPU hot unplug is currently
> >> not supported by the architecture.
> >>
> >> Support for hotplugging CPUs in random core-id order (last two patches)
> >> is added. We once hat a KVM bug preventing this, but the stable patch
> >> should now be included in relevant places - 152e9f65d66f ("KVM: s390: fix
> >> wrong lookup of VCPUs by array index"). Current tooling will plug them in
> >> sequential order anyway, so it should not hurt.
> >
> > Thanks, applied.
>
> Please squash in the one-liner fix I asked for in my (late!) review of
> PATCH 18.
Sadly, the review was a bit too late (already merged)...