qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency
Date: Mon, 2 Oct 2017 15:52:33 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

Hi Thomas,

On 09/25/2017 02:38 AM, Thomas Huth wrote:
On 22.09.2017 18:01, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
  hw/alpha/alpha_sys.h | 2 --
  hw/alpha/pci.c       | 2 ++
  hw/alpha/typhoon.c   | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h
index b6d8369ed7..ac685c1c46 100644
--- a/hw/alpha/alpha_sys.h
+++ b/hw/alpha/alpha_sys.h
@@ -5,8 +5,6 @@
#include "target/alpha/cpu-qom.h"
  #include "hw/pci/pci.h"
-#include "hw/pci/pci_host.h"
-#include "hw/ide.h"
  #include "hw/i386/pc.h"

Didn't you want to remove that pc.h line according to the patch description?

Not yet :( This include is still needed for the i8259 PIC. This change is done in the part 2 (following series).

That said, I should improve the patch description :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]