[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] x86: Correct translation of some rdgsbase and w
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH] x86: Correct translation of some rdgsbase and wrgsbase encodings |
Date: |
Fri, 29 Sep 2017 16:43:29 -0300 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Thu, Sep 28, 2017 at 10:17:06AM -0700, Todd Eisenberger via Qemu-devel wrote:
> It looks like there was a transcription error when writing this code
> initially. The code previously only decoded src or dst of rax. This
> resolves
> https://bugs.launchpad.net/qemu/+bug/1719984.
>
> Signed-off-by: Todd Eisenberger <address@hidden>
> ---
> target/i386/translate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/i386/translate.c b/target/i386/translate.c
> index a8986f4c1a..7b920115f9 100644
> --- a/target/i386/translate.c
> +++ b/target/i386/translate.c
> @@ -8155,9 +8155,9 @@ static target_ulong disas_insn(DisasContext *s,
> CPUState *cpu)
The patch is corrupted due to line wrapping. I recommend using
git-send-email to avoid that.
I'm queueing it on x86-next after fixing it manually.
> break;
>
> case 0xc0 ... 0xc7: /* rdfsbase (f3 0f ae /0) */
> - case 0xc8 ... 0xc8: /* rdgsbase (f3 0f ae /1) */
> + case 0xc8 ... 0xcf: /* rdgsbase (f3 0f ae /1) */
> case 0xd0 ... 0xd7: /* wrfsbase (f3 0f ae /2) */
> - case 0xd8 ... 0xd8: /* wrgsbase (f3 0f ae /3) */
> + case 0xd8 ... 0xdf: /* wrgsbase (f3 0f ae /3) */
> if (CODE64(s)
> && (prefixes & PREFIX_REPZ)
> && !(prefixes & PREFIX_LOCK)
>
--
Eduardo