[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return numbe
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return number of config groups |
Date: |
Thu, 28 Sep 2017 17:54:24 -0300 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Sep 27, 2017 at 03:49:55PM -0500, Eric Blake wrote:
> On 09/27/2017 03:41 PM, Eduardo Habkost wrote:
> > Change qemu_config_parse() to return the number of config groups
> > in success and -EINVAL on error. This will allow callers of
> > qemu_config_parse() to check if something was really loaded from
> > the config file.
> >
> > All existing callers of qemu_config_parse() and
> > qemu_read_config_file() only check if the return value was
> > negative, so the change shouldn't affect them.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
>
> Reviewed-by: Eric Blake <address@hidden>
>
> > Changes v2 -> v3:
> > * None (rebase only)
> >
> > Changes v1 -> v2:
> > * Remove unnecessary translation of qemu_config_parse()
> > erros to -EINVAL at block/blkdebug.c:read_config()
> > * Suggsted-by: Markus Armbruster <address@hidden>
>
> Do you want the Suggested-by (spelled correctly) in the commit body proper?
This line refers to a one-line change in the patch between v1 and
v2, only. Doesn't seem appropriate for a Suggested-by line in
the commit message.
--
Eduardo