[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 1/6] s390x/tcg: fix checking for invalid memory c
From: |
David Hildenbrand |
Subject: |
[Qemu-devel] [PATCH v1 1/6] s390x/tcg: fix checking for invalid memory check |
Date: |
Tue, 26 Sep 2017 20:33:13 +0200 |
It should have been a >=, but let's directly perform a proper access
check to also be able to deal with hotplugged memory later.
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/excp_helper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c
index 470cf8f5bc..308605d9ed 100644
--- a/target/s390x/excp_helper.c
+++ b/target/s390x/excp_helper.c
@@ -26,6 +26,7 @@
#include "exec/exec-all.h"
#include "exec/cpu_ldst.h"
#include "hw/s390x/ioinst.h"
+#include "exec/address-spaces.h"
#ifndef CONFIG_USER_ONLY
#include "sysemu/sysemu.h"
#endif
@@ -108,7 +109,8 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr
orig_vaddr,
}
/* check out of RAM access */
- if (raddr > ram_size) {
+ if (!address_space_access_valid(&address_space_memory, raddr,
+ TARGET_PAGE_SIZE, rw)) {
DPRINTF("%s: raddr %" PRIx64 " > ram_size %" PRIx64 "\n", __func__,
(uint64_t)raddr, (uint64_t)ram_size);
trigger_pgm_exception(env, PGM_ADDRESSING, ILEN_AUTO);
--
2.13.5
- [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using low address, David Hildenbrand, 2017/09/26
- [Qemu-devel] [PATCH v1 1/6] s390x/tcg: fix checking for invalid memory check,
David Hildenbrand <=
- [Qemu-devel] [PATCH v1 2/6] s390x/tcg: add MMU for real addresses, David Hildenbrand, 2017/09/26
- [Qemu-devel] [PATCH v1 3/6] s390x/tcg: make lura(g) use the new _real mmu., David Hildenbrand, 2017/09/26
- [Qemu-devel] [PATCH v1 4/6] s390x/tcg: make stora(g) use the new _real mmu, David Hildenbrand, 2017/09/26
- [Qemu-devel] [PATCH v1 5/6] s390x/tcg: make testblock use the new _real mmu, David Hildenbrand, 2017/09/26
- [Qemu-devel] [PATCH v1 6/6] s390x/tcg: make idte/ipte use the new _real mmu, David Hildenbrand, 2017/09/26
- Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using low address, Richard Henderson, 2017/09/26
- Re: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using low address, Cornelia Huck, 2017/09/27