[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/43] windbg: added WindbgState
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH 06/43] windbg: added WindbgState |
Date: |
Tue, 26 Sep 2017 10:17:46 -0700 |
On Tue, Sep 26, 2017 at 4:04 AM, Mihail Abakumov
<address@hidden> wrote:
> Added definition of the WindbgState struct and its initialization.
>
> Signed-off-by: Mihail Abakumov <address@hidden>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> Signed-off-by: Dmitriy Koltunov <address@hidden>
> ---
> windbgstub.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/windbgstub.c b/windbgstub.c
> index 3830446988..60a380c213 100755
> --- a/windbgstub.c
> +++ b/windbgstub.c
> @@ -10,10 +10,36 @@
> */
>
> #include "qemu/osdep.h"
> +#include "chardev/char.h"
> +#include "chardev/char-fe.h"
> #include "exec/windbgstub.h"
> #include "exec/windbgstub-utils.h"
>
> +typedef struct WindbgState {
> + bool is_loaded;
> +
> + uint32_t ctrl_packet_id;
> + uint32_t data_packet_id;
> +} WindbgState;
> +
> +static WindbgState *windbg_state;
> +
> +static void windbg_exit(void)
> +{
> + g_free(windbg_state);
> +}
> +
> int windbg_server_start(const char *device)
> {
> + if (windbg_state) {
> + WINDBG_ERROR("Multiple instances are not supported");
Use error_report() to report errors.
Thanks,
Alistair
> + exit(1);
> + }
> +
> + windbg_state = g_new0(WindbgState, 1);
> + windbg_state->ctrl_packet_id = RESET_PACKET_ID;
> + windbg_state->data_packet_id = INITIAL_PACKET_ID;
> +
> + atexit(windbg_exit);
I don't think you need this.
Thanks,
Alistair
> return 0;
> }
>
>
- [Qemu-devel] [PATCH 00/43] Windbg supporting, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 01/43] windbg: added empty windbgstub files, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 02/43] windbg: added windbg's KD header file, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 03/43] windbg: modified windbgkd.h, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 04/43] windbg: added '-windbg' option, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 05/43] windbg: added helper features, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 06/43] windbg: added WindbgState, Mihail Abakumov, 2017/09/26
- Re: [Qemu-devel] [PATCH 06/43] windbg: added WindbgState,
Alistair Francis <=
- [Qemu-devel] [PATCH 07/43] windbg: added chardev, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 09/43] windbg: handler of fs/gs register, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 08/43] windbg: hook to wrmsr operation, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 10/43] windbg: structures for parsing data stream, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 12/43] windbg: send data and control packets, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 13/43] windbg: handler of parsing context, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 11/43] windbg: parsing data stream, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 14/43] windbg: init DBGKD_ANY_WAIT_STATE_CHANGE, Mihail Abakumov, 2017/09/26
- [Qemu-devel] [PATCH 15/43] windbg: sized data buffer, Mihail Abakumov, 2017/09/26