Re: [Qemu-devel] [PATCH v3 1/4] qom: provide root container for internal objs

[Stefan Hajnoczi]

On Tue, Sep 26, 2017 at 12:52:09PM +0800, Peter Xu wrote:
> diff --git a/include/qom/object.h b/include/qom/object.h
> index f3e5cff..f567052 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1214,6 +1214,16 @@ Object *object_get_root(void);
>  Object *object_get_objects_root(void);
>  
>  /**
> + * object_get_internal_root:
> + *
> + * Get the container object that holds internally used object
> + * instances. This is the object at path "/internal-objects"

When you update the comment, please mention that this root is for
objects that must not be user-visible.  This root is not exposed in the
qom tree.

I think mentioning this will help others understand the purpose of the
internal root.