Re: [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore

[Juergen Gross]

On 25/09/17 17:08, Anthony PERARD wrote:
> On Fri, Sep 22, 2017 at 02:14:16PM +0200, Juergen Gross wrote:
>> On 15/09/17 20:09, Ian Jackson wrote:
>>> Signed-off-by: Ian Jackson <address@hidden>
>>> ---
>>>  configure | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index fd7e3a5..c59a0c0 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2072,14 +2072,14 @@ if test "$xen" != "no" ; then
>>>        $($pkg_config --modversion xencontrol | sed 's/\./ /g') )"
>>>      xen=yes
>>>      xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab"
>>> -    xen_pc="$xen_pc xenevtchn xendevicemodel"
>>> +    xen_pc="$xen_pc xenevtchn xendevicemodel xentoolcore"
>>>      QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)"
>>>      libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu"
>>>      LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS"
>>>    else
>>>  
>>>      xen_libs="-lxenstore -lxenctrl -lxenguest"
>>> -    xen_stable_libs="-lxenforeignmemory -lxengnttab -lxenevtchn"
>>> +    xen_stable_libs="-lxenforeignmemory -lxengnttab -lxenevtchn 
>>> -lxentoolcore"
>>
>> I don't think this is necessary. libxentoolcore is only available with
>> a new Xen, which will always have the xentoolcore.pc file installed.
> 
> Only if ! echo $EXTRA_LDFLAGS | grep tools/libxc;
> 
> So building qemu via xen.git Makefiles, the pkg-config files are not
> taken into account.
> 

Aah, right, this patch for the Xen build system is still missing.

In Xen 4.11 we should drop passing all the flags to configure and use
the pkg-config files instead.


Juergen