qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] ide: fix enum comparison for gcc 4.7


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] ide: fix enum comparison for gcc 4.7
Date: Fri, 22 Sep 2017 14:03:05 +0100

On 21 September 2017 at 13:25, Stefan Hajnoczi <address@hidden> wrote:
> On Wed, Sep 20, 2017 at 09:38:21PM -0400, John Snow wrote:
>> Apparently GCC gets bent over comparing enum values against zero.
>> Replace the conditional with something less readable.
>>
>> Tested-by: Mark Cave-Ayland <address@hidden>
>> Signed-off-by: John Snow <address@hidden>
>>
>> ---
>>
>> v2: Second verse, same as the first.
>> Signed-off-by: John Snow <address@hidden>
>> ---
>>  hw/ide/ahci.c             | 2 +-
>>  hw/ide/core.c             | 2 +-
>>  include/hw/ide/internal.h | 3 +--
>>  3 files changed, 3 insertions(+), 4 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>

Thanks, applied to master as a buildfix.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]