Re: [Qemu-devel] [PATCH v2 0/3] Implement basic MSA functions

[David Hildenbrand]

On 20.09.2017 17:14, Cornelia Huck wrote:
> On Tue, 19 Sep 2017 16:26:51 +0200
> David Hildenbrand <address@hidden> wrote:
> 
>> Some leftover from "target/s390x: tcg improvments + MSA functions".
>>
>> Implement all basic MSA (cpacf/crypto) instructions <= z13. Only provide
>> the query subfunction (to query available subfunctions), no actual
>> de/encryption yet. Good enough to unlock the STFL bits.
>>
>> I have written kvm-unit-tests for MSA functions and for SPM/IPM. Will
>> send them out soon. I use the following cpu model to test with an upstream
>> kernel compiled for z10:
>>
>> ... -cpu qemu,mvcos=on,stfle=on,ldisp=on,ldisphp=on,\
>>               eimm=on,stckf=on,csst=on,csst2=on,ginste=on,\
>>               exrl=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on ...
>>
>> Based on: https://github.com/cohuck/qemu.git s390-next
>> Available on: https://github.com/davidhildenbrand/qemu.git s390x-msa
> 
> Do I understand correctly that you'll send a v3 with changes to patch 3?
> 
> If yes, I'll just wait and pick that.
> 

It is really just dropping one superfluous check in patch nr 3.

So you can either fix that up or I can resend, whatever you prefer.

-- 

Thanks,

David