[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 07/16] migration: Create x-multifd-page-count par
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 07/16] migration: Create x-multifd-page-count parameter |
Date: |
Wed, 20 Sep 2017 08:59:49 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/20/2017 05:46 AM, Juan Quintela wrote:
> Indicates how many pages we are going to send in each batch to a multifd
> thread.
>
> Signed-off-by: Juan Quintela <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>
>
> +++ b/qapi/migration.json
> @@ -471,6 +471,9 @@
> # number of sockets used for migration. The
> # default value is 2 (since 2.11)
> #
> +# @x-multifd-page-count: Number of pages sent together to a thread
> +# The default value is 16 (since 2.11)
You're missing a '.' between sentences; it's more obvious when you no
longer have a newline between them when things are rendered to other
documentation formats.
Can be fixed as a followup.
> @@ -539,6 +542,9 @@
> # number of sockets used for migration. The
> # default value is 2 (since 2.11)
> #
> +# @x-multifd-page-count: Number of pages sent together to a thread
> +# The default value is 16 (since 2.11)
> +#
Multiple instances of it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 09/16] migration: Split migration_fd_process_incoming, (continued)
- [Qemu-devel] [PULL 09/16] migration: Split migration_fd_process_incoming, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 10/16] bitmap: remove BITOP_WORD(), Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 13/16] migration: pass MigrationIncomingState* into migration check functions, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 03/16] migration: Add comments to channel functions, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 05/16] migration: Add multifd capability, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 06/16] migration: Create x-multifd-channels parameter, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 08/16] migration: Create multifd migration threads, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 01/16] migration: Create migration_ioc_process_incoming(), Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 14/16] migration: fix hardcoded function name in error report, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 07/16] migration: Create x-multifd-page-count parameter, Juan Quintela, 2017/09/20
- Re: [Qemu-devel] [PULL 07/16] migration: Create x-multifd-page-count parameter,
Eric Blake <=
- [Qemu-devel] [PULL 16/16] migration: introduce postcopy-blocktime capability, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 15/16] migration: split ufd_version_check onto receive/request features part, Juan Quintela, 2017/09/20
- [Qemu-devel] [PULL 11/16] bitmap: introduce bitmap_count_one(), Juan Quintela, 2017/09/20
- Re: [Qemu-devel] [PULL 00/16] Migration PULL request, Juan Quintela, 2017/09/20
- Re: [Qemu-devel] [PULL 00/16] Migration PULL request, no-reply, 2017/09/20