[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 03/13] scripts: Add archive-source.sh
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v9 03/13] scripts: Add archive-source.sh |
Date: |
Tue, 19 Sep 2017 10:10:19 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/19/2017 02:27 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> scripts/archive-source.sh | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100755 scripts/archive-source.sh
>
> diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh
> new file mode 100755
> index 0000000000..e155d980ee
> --- /dev/null
> +++ b/scripts/archive-source.sh
> @@ -0,0 +1,46 @@
> +#!/bin/sh
Needs to be /bin/bash...
> + git ls-files || error "git ls-files failed"
> + for sm in $submodules; do
> + (cd $sm; git ls-files) | sed "s:^:$sm/:"
> + if test ${PIPESTATUS[0]} -ne 0 -o $? -ne 0; then
> + error "git ls-files in submodule $sm failed"
...because $PIPESTATUS is a useful bashism not present in dash, where
the alternative is MUCH more verbose and painful to write in portable shell.
With just that fixed,
Reviewed-by: Eric Blake <address@hidden>
If desired, one other change (not mandatory, but if you want to do it,
I'll want to re-review):
> +
> +tar -cf "$1" -T "$1".list || error "failed to create tar file"
If we exit here, $1.list is not removed...
> +rm "$1".list
Should we make removal of the list be controlled by a cleanup trap, to
always happen even if something else fails in the interim? Or is
leaving it around on failure useful for debugging?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v9 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux), Fam Zheng, 2017/09/19
- [Qemu-devel] [PATCH v9 01/13] gitignore: Ignore vm test images, Fam Zheng, 2017/09/19
- [Qemu-devel] [PATCH v9 02/13] qemu.py: Add "wait()" method, Fam Zheng, 2017/09/19
- [Qemu-devel] [PATCH v9 03/13] scripts: Add archive-source.sh, Fam Zheng, 2017/09/19
- [Qemu-devel] [PATCH v9 04/13] tests: Add a test key pair, Fam Zheng, 2017/09/19
- [Qemu-devel] [PATCH v9 05/13] tests: Add vm test lib, Fam Zheng, 2017/09/19
- [Qemu-devel] [PATCH v9 07/13] tests: Add FreeBSD image, Fam Zheng, 2017/09/19
- [Qemu-devel] [PATCH v9 06/13] tests: Add ubuntu.i386 image, Fam Zheng, 2017/09/19