Re: [Qemu-devel] [PATCH v3 0/2] Virtio GPU for S390

[Cornelia Huck]

On Fri, 15 Sep 2017 10:40:30 -0400
Farhan Ali <address@hidden> wrote:

> These patches wire up the virtio-gpu device for CCW bus for
> S390.
> 
> For the S390 architecture which does not natively support any graphics
> device, virtio gpu in 2D mode could be used to emulate a simple graphics
> card and use VNC as the display.
> 
> eg: qemu-system-s390x ... -device virtio-gpu-ccw,devno=fe.0.0101
>     -vnc host_ip_addr:5900
> 
> Note, to actually see any display content the
> guest kernel needs to support DRM layer, Virtio GPU driver,
> the Virtual Terminal layer etc.
> 
> I would appreciate any feedback on these patches, specially the
> first patch.
> 
> ChangeLog
> --------
> v1 -> v2
>     - remove error_propagate (patch 2)
>     - Add byteswap functions (patch 1)
>     - Handle endian conversion for virtio_gpu_ctrl_response (patch 1)
> 
> v2 -> v3
>     - updated patch 1 based on Gerd's feedback
>     - rename bswap functions (patch 1)
>     - use in-place swapping functions (patch 1)
>     - Handle endian conversion for cursor update (patch 1)
> 
> Thank you
> Farhan
> 
> 
> Farhan Ali (2):
>   virtio-gpu: Handle endian conversion
>   virtio-gpu-ccw: Create a virtio gpu device for the ccw bus
> 
>  hw/display/virtio-gpu.c | 70 
> +++++++++++++++++++++++++++++++++++++++++++------
>  hw/s390x/virtio-ccw.c   | 49 ++++++++++++++++++++++++++++++++++
>  hw/s390x/virtio-ccw.h   | 10 +++++++
>  3 files changed, 121 insertions(+), 8 deletions(-)
> 

Thanks, applied.