[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/9] libqtest: Remove dead qtest_instances variable
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PULL 8/9] libqtest: Remove dead qtest_instances variable |
Date: |
Fri, 15 Sep 2017 10:02:28 +0200 |
From: Eric Blake <address@hidden>
Prior to commit 063c23d9, we were tracking a list of parallel
qtest objects, in order to safely clean up a SIGABRT handler
only after the last connection quits. But when we switched to
more of glib's infrastructure, the list became dead code that
is never assigned to.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
tests/libqtest.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 3daa0e3..cbd7094 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -42,7 +42,6 @@ struct QTestState
};
static GHookList abrt_hooks;
-static GList *qtest_instances;
static struct sigaction sigact_old;
#define g_assert_no_errno(ret) do { \
@@ -247,13 +246,10 @@ QTestState *qtest_init(const char *extra_args)
void qtest_quit(QTestState *s)
{
- qtest_instances = g_list_remove(qtest_instances, s);
g_hook_destroy_link(&abrt_hooks, g_hook_find_data(&abrt_hooks, TRUE, s));
/* Uninstall SIGABRT handler on last instance */
- if (!qtest_instances) {
- cleanup_sigabrt_handler();
- }
+ cleanup_sigabrt_handler();
kill_qemu(s);
close(s->fd);
--
1.8.3.1
- [Qemu-devel] [PULL 0/9] Fixes and improvements for various qtests, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 1/9] tests: Introduce generic device hot-plug/hot-unplug functions, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 2/9] tests/test-hmp: Remove puv3 and tricore_testboard from the blacklist, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 3/9] tests/libqtest: Use a proper error message if QTEST_QEMU_BINARY is missing, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 4/9] tests: Fix broken ivshmem-server-msi/-irq tests, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 7/9] numa-test: Use hmp(), Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 6/9] qtest: Don't perform side effects inside assertion, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 5/9] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 9/9] qtest: Avoid passing raw strings through hmp(), Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 8/9] libqtest: Remove dead qtest_instances variable,
Thomas Huth <=
- Re: [Qemu-devel] [PULL 0/9] Fixes and improvements for various qtests, Peter Maydell, 2017/09/15