[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] nvic: Don't apply group priority mask to ne
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] nvic: Don't apply group priority mask to negative priorities |
Date: |
Wed, 13 Sep 2017 08:58:12 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/11/2017 06:52 AM, Peter Maydell wrote:
> In several places we were unconditionally applying the
> nvic_gprio_mask() to a priority value. This is incorrect
> if the priority is one of the fixed negative priority
> values (for NMI and HardFault), so don't do it.
>
> This bug would have caused both NMI and HardFault to be
> considered as the same priority and so NMI wouldn't
> correctly preempt HardFault.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/intc/armv7m_nvic.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/7] ARMv8M: some bugfixes and prep. cleanup, Peter Maydell, 2017/09/11
- [Qemu-devel] [PATCH 4/7] nvic: Don't apply group priority mask to negative priorities, Peter Maydell, 2017/09/11
- Re: [Qemu-devel] [PATCH 4/7] nvic: Don't apply group priority mask to negative priorities,
Richard Henderson <=
- [Qemu-devel] [PATCH 3/7] target/arm: Get PRECISERR and IBUSERR the right way round, Peter Maydell, 2017/09/11
- [Qemu-devel] [PATCH 7/7] target/arm: Rename 'type' to 'excret' in do_v7m_exception_exit(), Peter Maydell, 2017/09/11
- [Qemu-devel] [PATCH 2/7] target/arm: Clear exclusive monitor on v7M reset, exception entry/exit, Peter Maydell, 2017/09/11