[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 00/13] tests: Add VM based build tests (for n
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v7 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) |
Date: |
Tue, 12 Sep 2017 20:15:08 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v7 00/13] tests: Add VM based build tests (for
non-x86_64 and/or non-Linux)
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
t [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2a093b5b91 docker: Use archive-source.py
d2593fa09c tests: Add README for vm tests
fb3acd78df MAINTAINERS: Add tests/vm entry
90ed120035 Makefile: Add rules to run vm tests
0ce88831a3 tests: Add OpenBSD image
d5f133ecf2 tests: Add NetBSD image
da78075e20 tests: Add FreeBSD image
d1f4a3a768 tests: Add ubuntu.i386 image
ecb8ea14ca tests: Add vm test lib
fb1ed69ecc tests: Add a test key pair
ab63dd9b38 scripts: Add archive-source.sh
1c4bcf6389 qemu.py: Add "wait()" method
6376f7d0bb gitignore: Ignore vm test images
=== OUTPUT BEGIN ===
Checking PATCH 1/13: gitignore: Ignore vm test images...
Checking PATCH 2/13: qemu.py: Add "wait()" method...
Checking PATCH 3/13: scripts: Add archive-source.sh...
Checking PATCH 4/13: tests: Add a test key pair...
Checking PATCH 5/13: tests: Add vm test lib...
WARNING: line over 80 characters
#71: FILE: tests/vm/basevm.py:46:
+ self._tmpdir = tempfile.mkdtemp(prefix="vm-test-", suffix=".tmp",
dir=".")
WARNING: line over 80 characters
#162: FILE: tests/vm/basevm.py:137:
+ logging.debug("Creating archive %s for src_dir dir: %s", tarfile,
src_dir)
WARNING: line over 80 characters
#167: FILE: tests/vm/basevm.py:142:
+ "file=%s,if=none,id=%s,cache=writeback,format=raw"
% \
WARNING: line over 80 characters
#170: FILE: tests/vm/basevm.py:145:
+ "virtio-blk,drive=%s,serial=%s,bootindex=1" %
(name, name)]
ERROR: line over 90 characters
#225: FILE: tests/vm/basevm.py:200:
+ VM test utility. Exit codes: 0 = success, 1 = command line error, 2 =
environment initialization failed, 3 = test command failed""")
WARNING: line over 80 characters
#232: FILE: tests/vm/basevm.py:207:
+ parser.add_option("--jobs", type=int, default=multiprocessing.cpu_count()
/ 2,
total: 1 errors, 5 warnings, 256 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/13: tests: Add ubuntu.i386 image...
Checking PATCH 7/13: tests: Add FreeBSD image...
Checking PATCH 8/13: tests: Add NetBSD image...
Checking PATCH 9/13: tests: Add OpenBSD image...
Checking PATCH 10/13: Makefile: Add rules to run vm tests...
Checking PATCH 11/13: MAINTAINERS: Add tests/vm entry...
Checking PATCH 12/13: tests: Add README for vm tests...
Checking PATCH 13/13: docker: Use archive-source.py...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v7 04/13] tests: Add a test key pair, (continued)
- [Qemu-devel] [PATCH v7 04/13] tests: Add a test key pair, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 05/13] tests: Add vm test lib, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 06/13] tests: Add ubuntu.i386 image, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 07/13] tests: Add FreeBSD image, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 08/13] tests: Add NetBSD image, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 09/13] tests: Add OpenBSD image, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 10/13] Makefile: Add rules to run vm tests, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 11/13] MAINTAINERS: Add tests/vm entry, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 12/13] tests: Add README for vm tests, Fam Zheng, 2017/09/12
- [Qemu-devel] [PATCH v7 13/13] docker: Use archive-source.py, Fam Zheng, 2017/09/12
- Re: [Qemu-devel] [PATCH v7 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux),
no-reply <=