Re: [Qemu-devel] [PATCH v2 00/16] TCG vectorization and example conversion

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 00/16] TCG vectorization and example conversion
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
79dcc568d9 tcg/aarch64: Add vector operations
2775845e94 tcg: Fix types in tcg_regset_{set, reset}_reg
abc6fe1c86 tcg: Remove tcg_regset_set32
fa12f2aa97 tcg: Remove tcg_regset_{or, and, andnot, not}
e28741ea78 tcg: Remove tcg_regset_set
41300b5435 tcg: Remove tcg_regset_clear
af03c3a726 tcg/aarch64: Fully convert tcg_target_op_def
a3963f01e8 tcg/i386: Add vector operations
cb325eb085 target/arm: Use vector infrastructure for aa64 add/sub/logic
d47e03fb01 target/arm: Align vector registers
fbc24565b8 tcg: Add vector infrastructure and ops for add/sub/logic
d707cf2ec8 tcg: Add INDEX_op_invalid
c11bb78f2d tcg: Add tcg_op_supported
32b7f64cc9 tcg: Add operations for host vectors
79f62e0aec tcg: Add types for host vectors
3aaf410faf tcg: Add expanders for out-of-line vector helpers

=== OUTPUT BEGIN ===
Checking PATCH 1/16: tcg: Add expanders for out-of-line vector helpers...
Checking PATCH 2/16: tcg: Add types for host vectors...
Checking PATCH 3/16: tcg: Add operations for host vectors...
Checking PATCH 4/16: tcg: Add tcg_op_supported...
Checking PATCH 5/16: tcg: Add INDEX_op_invalid...
Checking PATCH 6/16: tcg: Add vector infrastructure and ops for add/sub/logic...
ERROR: spaces required around that '&' (ctx:WxO)
#778: FILE: tcg/tcg-runtime-gvec.c:178:
+        *(vec64 *)(d + i) = *(vec64 *)(a + i) &~ *(vec64 *)(b + i);
                                               ^

ERROR: space prohibited after that '~' (ctx:OxW)
#778: FILE: tcg/tcg-runtime-gvec.c:178:
+        *(vec64 *)(d + i) = *(vec64 *)(a + i) &~ *(vec64 *)(b + i);
                                                ^

ERROR: spaces required around that '|' (ctx:WxO)
#789: FILE: tcg/tcg-runtime-gvec.c:189:
+        *(vec64 *)(d + i) = *(vec64 *)(a + i) |~ *(vec64 *)(b + i);
                                               ^

ERROR: space prohibited after that '~' (ctx:OxW)
#789: FILE: tcg/tcg-runtime-gvec.c:189:
+        *(vec64 *)(d + i) = *(vec64 *)(a + i) |~ *(vec64 *)(b + i);
                                                ^

total: 4 errors, 0 warnings, 808 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/16: target/arm: Align vector registers...
Checking PATCH 8/16: target/arm: Use vector infrastructure for aa64 
add/sub/logic...
Checking PATCH 9/16: tcg/i386: Add vector operations...
WARNING: architecture specific defines should be avoided
#50: FILE: tcg/i386/tcg-target.h:93:
+#ifdef __SSE2__

WARNING: architecture specific defines should be avoided
#55: FILE: tcg/i386/tcg-target.h:98:
+#ifdef __AVX2__

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#558: FILE: tcg/i386/tcg-target.inc.c:2059:
+#define OP_128_256(x) \
+        case glue(glue(INDEX_op_, x), _v256): \
+            rexw = P_VEXL; /* FALLTHRU */     \
+        case glue(glue(INDEX_op_, x), _v128)

ERROR: spaces required around that ':' (ctx:VxE)
#574: FILE: tcg/i386/tcg-target.inc.c:2463:
+    OP_64_128_256(add8):
                        ^

ERROR: spaces required around that ':' (ctx:VxE)
#577: FILE: tcg/i386/tcg-target.inc.c:2466:
+    OP_64_128_256(add16):
                         ^

ERROR: spaces required around that ':' (ctx:VxE)
#580: FILE: tcg/i386/tcg-target.inc.c:2469:
+    OP_64_128_256(add32):
                         ^

ERROR: spaces required around that ':' (ctx:VxE)
#583: FILE: tcg/i386/tcg-target.inc.c:2472:
+    OP_128_256(add64):
                      ^

ERROR: spaces required around that ':' (ctx:VxE)
#586: FILE: tcg/i386/tcg-target.inc.c:2475:
+    OP_64_128_256(sub8):
                        ^

ERROR: spaces required around that ':' (ctx:VxE)
#589: FILE: tcg/i386/tcg-target.inc.c:2478:
+    OP_64_128_256(sub16):
                         ^

ERROR: spaces required around that ':' (ctx:VxE)
#592: FILE: tcg/i386/tcg-target.inc.c:2481:
+    OP_64_128_256(sub32):
                         ^

ERROR: spaces required around that ':' (ctx:VxE)
#595: FILE: tcg/i386/tcg-target.inc.c:2484:
+    OP_128_256(sub64):
                      ^

ERROR: spaces required around that ':' (ctx:VxE)
#598: FILE: tcg/i386/tcg-target.inc.c:2487:
+    OP_64_128_256(and):
                       ^

ERROR: spaces required around that ':' (ctx:VxE)
#601: FILE: tcg/i386/tcg-target.inc.c:2490:
+    OP_64_128_256(or):
                      ^

ERROR: spaces required around that ':' (ctx:VxE)
#604: FILE: tcg/i386/tcg-target.inc.c:2493:
+    OP_64_128_256(xor):
                       ^

ERROR: spaces required around that ':' (ctx:VxE)
#613: FILE: tcg/i386/tcg-target.inc.c:2502:
+    OP_64_128_256(andc):
                        ^

total: 13 errors, 2 warnings, 755 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/16: tcg/aarch64: Fully convert tcg_target_op_def...
Checking PATCH 11/16: tcg: Remove tcg_regset_clear...
Checking PATCH 12/16: tcg: Remove tcg_regset_set...
Checking PATCH 13/16: tcg: Remove tcg_regset_{or, and, andnot, not}...
Checking PATCH 14/16: tcg: Remove tcg_regset_set32...
Checking PATCH 15/16: tcg: Fix types in tcg_regset_{set, reset}_reg...
Checking PATCH 16/16: tcg/aarch64: Add vector operations...
ERROR: spaces required around that ':' (ctx:VxE)
#466: FILE: tcg/aarch64/tcg-target.inc.c:1944:
+    VOP(add16):
               ^

ERROR: spaces required around that ':' (ctx:VxE)
#469: FILE: tcg/aarch64/tcg-target.inc.c:1947:
+    VOP(add32):
               ^

ERROR: spaces required around that ':' (ctx:VxE)
#476: FILE: tcg/aarch64/tcg-target.inc.c:1954:
+    VOP(sub8):
              ^

ERROR: spaces required around that ':' (ctx:VxE)
#479: FILE: tcg/aarch64/tcg-target.inc.c:1957:
+    VOP(sub16):
               ^

ERROR: spaces required around that ':' (ctx:VxE)
#482: FILE: tcg/aarch64/tcg-target.inc.c:1960:
+    VOP(sub32):
               ^

ERROR: spaces required around that ':' (ctx:VxE)
#489: FILE: tcg/aarch64/tcg-target.inc.c:1967:
+    VOP(neg8):
              ^

ERROR: spaces required around that ':' (ctx:VxE)
#492: FILE: tcg/aarch64/tcg-target.inc.c:1970:
+    VOP(neg16):
               ^

ERROR: spaces required around that ':' (ctx:VxE)
#495: FILE: tcg/aarch64/tcg-target.inc.c:1973:
+    VOP(neg32):
               ^

ERROR: spaces required around that ':' (ctx:VxE)
#502: FILE: tcg/aarch64/tcg-target.inc.c:1980:
+    VOP(and):
             ^

ERROR: spaces required around that ':' (ctx:VxE)
#505: FILE: tcg/aarch64/tcg-target.inc.c:1983:
+    VOP(or):
            ^

ERROR: spaces required around that ':' (ctx:VxE)
#508: FILE: tcg/aarch64/tcg-target.inc.c:1986:
+    VOP(xor):
             ^

ERROR: spaces required around that ':' (ctx:VxE)
#511: FILE: tcg/aarch64/tcg-target.inc.c:1989:
+    VOP(andc):
              ^

ERROR: spaces required around that ':' (ctx:VxE)
#514: FILE: tcg/aarch64/tcg-target.inc.c:1992:
+    VOP(orc):
             ^

ERROR: spaces required around that ':' (ctx:VxE)
#517: FILE: tcg/aarch64/tcg-target.inc.c:1995:
+    VOP(not):
             ^

total: 14 errors, 0 warnings, 595 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden