[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 13/22] migration: Split migration_fd_process_
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v7 13/22] migration: Split migration_fd_process_incoming |
Date: |
Fri, 8 Sep 2017 18:22:58 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
* Juan Quintela (address@hidden) wrote:
> We need that on later patches.
>
> Signed-off-by: Juan Quintela <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>
> Reviewed-by: Daniel P. Berrange <address@hidden>
I think this could also go into current qemu?
Dave
> ---
> migration/migration.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 9fec880a58..18bd24a14c 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -372,9 +372,8 @@ static void process_incoming_migration_co(void *opaque)
> qemu_bh_schedule(mis->bh);
> }
>
> -void migration_fd_process_incoming(QEMUFile *f)
> +static void migration_incoming_setup(QEMUFile *f)
> {
> - Coroutine *co = qemu_coroutine_create(process_incoming_migration_co,
> NULL);
> MigrationIncomingState *mis = migration_incoming_get_current();
>
> if (multifd_load_setup() != 0) {
> @@ -387,9 +386,20 @@ void migration_fd_process_incoming(QEMUFile *f)
> mis->from_src_file = f;
> }
> qemu_file_set_blocking(f, false);
> +}
> +
> +static void migration_incoming_process(void)
> +{
> + Coroutine *co = qemu_coroutine_create(process_incoming_migration_co,
> NULL);
> qemu_coroutine_enter(co);
> }
>
> +void migration_fd_process_incoming(QEMUFile *f)
> +{
> + migration_incoming_setup(f);
> + migration_incoming_process();
> +}
> +
> void migration_ioc_process_incoming(QIOChannel *ioc)
> {
> MigrationIncomingState *mis = migration_incoming_get_current();
> --
> 2.13.5
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error, (continued)
- [Qemu-devel] [PATCH v7 09/22] migration: Add multifd capability, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 08/22] qio: Create new qio_channel_{readv, writev}_all, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 11/22] migration: Create x-multifd-group parameter, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 10/22] migration: Create x-multifd-threads parameter, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 12/22] migration: Create multifd migration threads, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 13/22] migration: Split migration_fd_process_incoming, Juan Quintela, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 13/22] migration: Split migration_fd_process_incoming,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v7 14/22] migration: Start of multiple fd work, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 15/22] migration: Create ram_multifd_page, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 17/22] migration: Send the fd number which we are going to use for this page, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 16/22] migration: Really use multiple pages at a time, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 19/22] migration: Test new fd infrastructure, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 20/22] migration: Rename initial_bytes, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 18/22] migration: Create thread infrastructure for multifd recv side, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 21/22] migration: Transfer pages over new channels, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 22/22] migration: Flush receive queue, Juan Quintela, 2017/09/06