Re: [Qemu-devel] [PULL 0/4] target/alpha queued patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 0/4] target/alpha queued patches
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ed15303b60 target/alpha: Switch to do_transaction_failed() hook
b9223923b6 target/alpha: Convert to TranslatorOps
8ad04070b6 target/alpha: Convert to DisasContextBase
06c614ec51 target/alpha: Convert to DisasJumpType

=== OUTPUT BEGIN ===
Checking PATCH 1/4: target/alpha: Convert to DisasJumpType...
Checking PATCH 2/4: target/alpha: Convert to DisasContextBase...
ERROR: return is not a function, parentheses are not required
#48: FILE: target/alpha/translate.c:464:
+    return ((ctx->base.tb->cflags & CF_LAST_IO)

total: 1 errors, 0 warnings, 242 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/4: target/alpha: Convert to TranslatorOps...
Checking PATCH 4/4: target/alpha: Switch to do_transaction_failed() hook...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden