[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] docker: Enable features explicitly in test-
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] docker: Enable features explicitly in test-full |
Date: |
Thu, 7 Sep 2017 08:37:09 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/07/2017 03:11 AM, Fam Zheng wrote:
> Also avoid "set -e".
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/docker/test-full | 80
> ++++++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 75 insertions(+), 5 deletions(-)
>
> diff --git a/tests/docker/test-full b/tests/docker/test-full
> index 05f0d491d1..bd095ad91b 100755
> --- a/tests/docker/test-full
> +++ b/tests/docker/test-full
> @@ -1,8 +1,8 @@
> -#!/bin/bash -e
> +#!/bin/bash
When you drop 'set -e'...
> #
> -# Compile all the targets.
> +# Compile all the targets with as many features enabled as possible
> #
> -# Copyright (c) 2016 Red Hat Inc.
> +# Copyright 2016, 2017 Red Hat Inc.
> #
> # Authors:
> # Fam Zheng <address@hidden>
> @@ -15,5 +15,75 @@
>
> cd "$BUILD_DIR"
...then you should explicitly check for failure after commands where you
really do not want to continue execution if they failed. I'd write this:
cd "$BUILD_DIR" || exit 1
or else use && to chain it to...
>
> -build_qemu
> -make check $MAKEFLAGS
> +build_qemu \
> + --enable-attr \
> + --enable-xfsctl \
> +&& make check $MAKEFLAGS
the rest of your chain.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature