qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc, s390x: don't in


From: David Hildenbrand
Subject: Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly
Date: Thu, 7 Sep 2017 14:41:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 07.09.2017 07:46, Thomas Huth wrote:
>>  #include "qemu/cutils.h"
>>  #include "cpu.h"
>> -#include "exec/exec-all.h"
> You should maybe mention exec-all.h in the patch description, too.
> (I think it can be dropped here because it is included by
> translate-all.h already).
> 
> If you tweak the patch description:
> Reviewed-by: Thomas Huth <address@hidden>

I'll just drop that hunk although it can also be removed.

Yes, this was not included on purpose - these similar names still
confuse me :)

-- 

Thanks,

David



reply via email to

[Prev in Thread] Current Thread [Next in Thread]