|
| From: | Daniel P. Berrange |
| Subject: | Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions" |
| Date: | Wed, 6 Sep 2017 17:32:05 +0100 |
| User-agent: | Mutt/1.8.3 (2017-05-23) |
On Wed, Sep 06, 2017 at 04:42:18PM +0200, Juan Quintela wrote: > Eric Blake <address@hidden> wrote: > > On 09/06/2017 06:51 AM, Juan Quintela wrote: > >> This reverts commit d4622e55883211072621958d39ddaa73483d201e. > > > > But with no reason why? What bugs are you fixing by reverting this? > > I put it on the cover letter. I am investigating *why* it fails on me. > It got the thread handed. Your functions return the number of bytes written. My impl only returns the 0 or -1 on the basis that the caller does not need to know how many bytes were written - its always exactly the amount asked for. You probably need to adjust your code to take that into account. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
| [Prev in Thread] | Current Thread | [Next in Thread] |