[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/5] iotests: blacklist 194 with the luks driver
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PULL 2/5] iotests: blacklist 194 with the luks driver |
Date: |
Wed, 6 Sep 2017 10:21:08 -0500 |
From: "Daniel P. Berrange" <address@hidden>
The 194 test has a lot of code that assumes a simple image file. Rewriting
this to work with luks is possible, but non-trivial, so blacklist the
luks format for now.
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Tested-by: Fam Zheng <address@hidden>
[eblake: commit message typo fixed]
Reviewed-by: Kashyap Chamarthy <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
---
tests/qemu-iotests/194 | 1 +
tests/qemu-iotests/iotests.py | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194
index 6449b9b64a..8d973b440f 100755
--- a/tests/qemu-iotests/194
+++ b/tests/qemu-iotests/194
@@ -21,6 +21,7 @@
import iotests
+iotests.verify_image_format(unsupported_fmts=['luks'])
iotests.verify_platform(['linux'])
with iotests.FilePath('source.img') as source_img_path, \
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 07fa1626a0..1af117e37d 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -421,9 +421,11 @@ def notrun(reason):
print '%s not run: %s' % (seq, reason)
sys.exit(0)
-def verify_image_format(supported_fmts=[]):
+def verify_image_format(supported_fmts=[], unsupported_fmts=[]):
if supported_fmts and (imgfmt not in supported_fmts):
notrun('not suitable for this image format: %s' % imgfmt)
+ if unsupported_fmts and (imgfmt in unsupported_fmts):
+ notrun('not suitable for this image format: %s' % imgfmt)
def verify_platform(supported_oses=['linux']):
if True not in [sys.platform.startswith(x) for x in supported_oses]:
--
2.13.5
- [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06, Eric Blake, 2017/09/06
- [Qemu-devel] [PULL 4/5] io: Add new qio_channel_read{, v}_all_eof functions, Eric Blake, 2017/09/06
- [Qemu-devel] [PULL 3/5] io: Yield rather than wait when already in coroutine, Eric Blake, 2017/09/06
- [Qemu-devel] [PULL 1/5] iotests: rewrite 192 to use _launch_qemu to fix LUKS support, Eric Blake, 2017/09/06
- [Qemu-devel] [PULL 2/5] iotests: blacklist 194 with the luks driver,
Eric Blake <=
- [Qemu-devel] [PULL 5/5] nbd: Use new qio_channel_*_all() functions, Eric Blake, 2017/09/06
- Re: [Qemu-devel] [PULL 0/5] NBD patches for 2017-09-06, Peter Maydell, 2017/09/07