[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally unre
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations |
|
Date: |
Wed, 6 Sep 2017 12:02:21 -0300 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Sep 06, 2017 at 03:00:41PM +0200, Kevin Wolf wrote:
> Am 30.08.2017 um 19:01 hat Jeff Cody geschrieben:
> > From: Jeffrey Cody <address@hidden>
> >
> > If configured without live block operations enabled, unregister the
> > live block operation commands.
> >
> > Signed-off-by: Jeff Cody <address@hidden>
>
> How sure are we that libvirt will like a qemu that advertises these
> commands in the schema, but doesn't actually provide them?
If libvirt wants to know if a command is available, it uses
'query-commands', not 'query-qmp-schema'.
The only query-qmp-schema elements used by latest libvirt are
gluster-related blockdev-add options (see
libvirt/src/qemu/qemu_capabilities.c:virQEMUCapsQMPSchemaQueries]]).
--
Eduardo