[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/14] block: remove bdrv_truncate callback in blkdeb
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 03/14] block: remove bdrv_truncate callback in blkdebug |
Date: |
Wed, 6 Sep 2017 16:02:35 +0200 |
From: Manos Pitsidianakis <address@hidden>
Now that bdrv_truncate is passed to bs->file by default, remove the
callback from block/blkdebug.c and set is_filter to true. is_filter also gives
access to other callbacks that are forwarded automatically to bs->file for
filters.
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Manos Pitsidianakis <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/blkdebug.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 8e385acf54..f10e3e5638 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -808,12 +808,6 @@ static int64_t blkdebug_getlength(BlockDriverState *bs)
return bdrv_getlength(bs->file->bs);
}
-static int blkdebug_truncate(BlockDriverState *bs, int64_t offset,
- PreallocMode prealloc, Error **errp)
-{
- return bdrv_truncate(bs->file, offset, prealloc, errp);
-}
-
static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options)
{
BDRVBlkdebugState *s = bs->opaque;
@@ -896,6 +890,7 @@ static BlockDriver bdrv_blkdebug = {
.format_name = "blkdebug",
.protocol_name = "blkdebug",
.instance_size = sizeof(BDRVBlkdebugState),
+ .is_filter = true,
.bdrv_parse_filename = blkdebug_parse_filename,
.bdrv_file_open = blkdebug_open,
@@ -904,7 +899,6 @@ static BlockDriver bdrv_blkdebug = {
.bdrv_child_perm = bdrv_filter_default_perms,
.bdrv_getlength = blkdebug_getlength,
- .bdrv_truncate = blkdebug_truncate,
.bdrv_refresh_filename = blkdebug_refresh_filename,
.bdrv_refresh_limits = blkdebug_refresh_limits,
--
2.13.5
- [Qemu-devel] [PULL 00/14] Block layer patches, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 02/14] block: remove unused bdrv_media_changed, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 05/14] qcow: Change signature of get_cluster_offset(), Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 03/14] block: remove bdrv_truncate callback in blkdebug,
Kevin Wolf <=
- [Qemu-devel] [PULL 06/14] qcow: Check failure of bdrv_getlength() and bdrv_truncate(), Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 01/14] block: pass bdrv_* methods to bs->file by default in block filters, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 10/14] block: tidy ThrottleGroupMember initializations, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 04/14] block: add default implementations for bdrv_co_get_block_status(), Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 07/14] block: document semantics of bdrv_co_preadv|pwritev, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 12/14] block: add throttle block filter driver, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 11/14] block: convert ThrottleGroup to object with QOM, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 08/14] block: move ThrottleGroup membership to ThrottleGroupMember, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 09/14] block: add aio_context field in ThrottleGroupMember, Kevin Wolf, 2017/09/06
- [Qemu-devel] [PULL 13/14] qemu-iotests: add 184 for throttle filter driver, Kevin Wolf, 2017/09/06