Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] tests: Add a device_add/del HMP test

[Thomas Huth]

On 05.09.2017 20:37, Dr. David Alan Gilbert wrote:
> * Thomas Huth (address@hidden) wrote:
>> On 05.09.2017 18:48, Dr. David Alan Gilbert wrote:
>>> * Markus Armbruster (address@hidden) wrote:
>>>> Thomas Huth <address@hidden> writes:
>>>>
>>>>> People tend to forget to mark internal devices with "user_creatable = 
>>>>> false
>>>>> or hotpluggable = false, and these devices can crash QEMU if added via the
>>>>> HMP monitor. So let's add a test to run through all devices and that tries
>>>>> to add them blindly (without arguments) to see whether this could crash 
>>>>> the
>>>>> QEMU instance.
>>>>>
>>>>> Signed-off-by: Thomas Huth <address@hidden>
>>>>> ---
[...]
>>> If I'm reading the code right it's creating the device with the same
>>> name as the device;  I wonder if that always works?
>>
>> Why not? The id is just an arbitrary string, isn't it?
> 
> I didn't know how arbitrary they were allowed to be and I was
> also worried they might clash with some existing id.
> As an example, I see there's at least one device (SUNW,fdtwo) with
> a , in it's name - is that legal for an id ?

Oh, right, I didn't think of comma :-/ ... I'll try to come up with a
better solution in the next version of the patch...

 Thomas