[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to int
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c |
|
Date: |
Tue, 5 Sep 2017 14:52:44 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 05.09.2017 14:46, Christian Borntraeger wrote:
>
>
> On 09/05/2017 02:42 PM, David Hildenbrand wrote:
>> On 05.09.2017 14:38, Cornelia Huck wrote:
>>> On Mon, 4 Sep 2017 17:43:05 +0200
>>> David Hildenbrand <address@hidden> wrote:
>>>
>>>> Fix up includes and rename it to s390x_*.
>>>
>>> I'm not quite sure whether that is the right direction: servc is just an
>>> instruction that does something and then happens to also generate an
>>> interrupt on conclusion. I'll think a bit more about it.
>>>
>>
>> Having CPU related stuff in sclp looks also wrong. Feel free to skip
>> this patch, should be unrelated to the following patches.
>
> I think having the sclp instruction handler in sclp (as today) is
> the best compromise.
+1
But maybe you could at least move the prototype to sclp.h instead?
Thomas
[Qemu-devel] [PATCH v2 09/19] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault(), David Hildenbrand, 2017/09/04
[Qemu-devel] [PATCH v2 10/19] target/s390x: use program_interrupt() in per_check_exception(), David Hildenbrand, 2017/09/04
[Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG, David Hildenbrand, 2017/09/04