qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup from b


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup from bash tests
Date: Tue, 5 Sep 2017 13:17:44 +0200
User-agent: Mutt/1.8.3 (2017-05-23)

Am 30.08.2017 um 18:52 hat Jeff Cody geschrieben:
> All files for a given test are now self-contained in a subdirectory,
> and therefore the "./check" script can do all file-related cleanup
> without any help.
> 
> This removes file cleanups from the bash tests.  The only cleanup left
> is whatever is needed to kill any spawned processes; e.g. _cleanup_qemu.
> 
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>

What about non-file protocols? _cleanup_test_img() does more than just a
few 'rm' commands. For NBD and vxhs it also kills the server process and
for sheepdog and rbd it uses their specific tools to delete the image
from the cluster because it's not simply a local file.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]