[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling |
Date: |
Tue, 05 Sep 2017 11:34:33 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 05 Sep 2017 11:13:09 AM CEST, Pradeep Jagadeesh wrote:
>> a) Declare an Error, pass it _and then handle it_ (if you don't
>> handle it, you're leaking it):
>>
>> Here you have no other way to know if qmp_query_fsdev_io_throttle()
>> fails, so you should choose (a).
>>
> OK, I will pass NULL.
:-)
(it's ok I guess, I don't see how that function can ever be made to fail
in the future)
Berto
- [Qemu-devel] [PATCH v10 3/6] throttle: move out function to reuse the code, (continued)
- [Qemu-devel] [PATCH v10 3/6] throttle: move out function to reuse the code, Pradeep Jagadeesh, 2017/09/04
- [Qemu-devel] [PATCH v10 1/6] throttle: factor out duplicate code, Pradeep Jagadeesh, 2017/09/04
- [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Pradeep Jagadeesh, 2017/09/04
- Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Alberto Garcia, 2017/09/05
- Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Pradeep Jagadeesh, 2017/09/05
- Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Greg Kurz, 2017/09/05
- Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Alberto Garcia, 2017/09/05
- Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Pradeep Jagadeesh, 2017/09/05
- Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling,
Alberto Garcia <=
- Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Pradeep Jagadeesh, 2017/09/05
Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Dr. David Alan Gilbert, 2017/09/05
[Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/09/04
- Re: [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling, Markus Armbruster, 2017/09/08
- Re: [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/09/08
- Re: [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling, Markus Armbruster, 2017/09/08
- Re: [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/09/08
- Re: [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/09/11