[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to cpu_par
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to cpu_parse_cpu_model() |
|
Date: |
Tue, 5 Sep 2017 07:38:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 04.09.2017 21:06, Igor Mammedov wrote:
> On Mon, 4 Sep 2017 12:03:09 -0300
> Philippe Mathieu-Daudé <address@hidden> wrote:
>
>> Hi Igor,
>>
>> On 09/04/2017 11:00 AM, Igor Mammedov wrote:
>>> function not just parses features but also converts CPU model
>>> name to CPU type, rename it to reflect what it actualy does.
>>
>> Why not squash this with your 1st patch "split cpu_generic_init()"?
> there I went with current/exiting way to call that part of code,
> and here I'm renaming it to show what it does exactly.
>
> But I don't have any preference here, so I can squash this patch
> into 1/6 on respin, if you prefer.
+1 for squashing
Thomas
[Qemu-devel] [PATCH 4/6] vl.c: convert cpu_model to cpu type and set of global properties before machine_init(), Igor Mammedov, 2017/09/04
[Qemu-devel] [PATCH 5/6] pc: use generic cpu_model parsing, Igor Mammedov, 2017/09/04
[Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error, Igor Mammedov, 2017/09/04