Re: [Qemu-devel] [PATCHv4 0/6] seccomp: feature refactoring

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCHv4 0/6] seccomp: feature refactoring
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b93c9e7648 seccomp: adding documentation to new seccomp model
19f0713063 seccomp: add resourcecontrol argument to command line
0d2a553bce seccomp: add spawn argument to command line
7899a23fb6 seccomp: add elevateprivileges argument to command line
d43b3cbcf8 seccomp: add obsolete argument to command line
2765752f8e seccomp: changing from whitelist to blacklist

=== OUTPUT BEGIN ===
Checking PATCH 1/6: seccomp: changing from whitelist to blacklist...
Checking PATCH 2/6: seccomp: add obsolete argument to command line...
ERROR: code indent should never use tabs
#128: FILE: vl.c:1048:
+^I^I * to provide a little bit of consistency for$

ERROR: code indent should never use tabs
#129: FILE: vl.c:1049:
+^I^I * the command line */$

ERROR: code indent should never use tabs
#130: FILE: vl.c:1050:
+^I    } else {$

ERROR: code indent should never use tabs
#131: FILE: vl.c:1051:
+^I^Ierror_report("invalid argument for obsolete");$

ERROR: code indent should never use tabs
#132: FILE: vl.c:1052:
+^I    }$

total: 5 errors, 0 warnings, 104 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/6: seccomp: add elevateprivileges argument to command line...
Checking PATCH 4/6: seccomp: add spawn argument to command line...
Checking PATCH 5/6: seccomp: add resourcecontrol argument to command line...
ERROR: space required after that ',' (ctx:VxV)
#78: FILE: qemu-seccomp.c:83:
+    { SCMP_SYS(sched_get_priority_max),16, QEMU_SECCOMP_SET_RESOURCECTL },
                                       ^

ERROR: space required after that ',' (ctx:VxV)
#79: FILE: qemu-seccomp.c:84:
+    { SCMP_SYS(sched_get_priority_min),16, QEMU_SECCOMP_SET_RESOURCECTL },
                                       ^

ERROR: code indent should never use tabs
#124: FILE: vl.c:1109:
+^I^Ierror_report("invalid argument for resourcecontrol");$

ERROR: code indent should never use tabs
#125: FILE: vl.c:1110:
+^I^Ireturn -1;$

ERROR: code indent should never use tabs
#126: FILE: vl.c:1111:
+^I    }$

total: 5 errors, 0 warnings, 95 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/6: seccomp: adding documentation to new seccomp model...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden