Re: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of version 2.10.0

[Thomas Huth]

On 01.09.2017 11:28, Daniel P. Berrange wrote:
> On Fri, Sep 01, 2017 at 12:22:41AM -0700, address@hidden wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
>>
>> Message-id: address@hidden
>> Subject: [Qemu-devel] [qemu-web PATCH] Add a blog post about the release of 
>> version 2.10.0
>> Type: series
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>>
>> BASE=base
>> n=1
>> total=$(git log --oneline $BASE.. | wc -l)
>> failed=0
>>
>> git config --local diff.renamelimit 0
>> git config --local diff.renames True
>>
>> commits="$(git log --format=%H --reverse $BASE..)"
>> for c in $commits; do
>>     echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
>> then
>>         failed=1
>>         echo
>>     fi
>>     n=$((n+1))
>> done
>>
>> exit $failed
>> === TEST SCRIPT END ===
>>
>> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>> From https://github.com/patchew-project/qemu
>>  * [new tag]               patchew/address@hidden -> patchew/address@hidden
>> Switched to a new branch 'test'
>> b70b83ae5d Add a blog post about the release of version 2.10.0
>>
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/1: Add a blog post about the release of version 2.10.0...
>> ERROR: trailing whitespace
>> #60: FILE: _posts/2017-09-01-qemu-2-10-0.md:43:
>> + * s390: support for z14 CPU models and netboot/TFTP via CCW BIOS, $
>>
>> total: 1 errors, 0 warnings, 56 lines checked
> 
> While it is nice that it identified the trailing whitespace in this
> case, does it really make sense for the patchew to be running the
> checkpatch.pl from qemu.git, against patches to qemu-web.git ?
> 
> Perhaps it should skip patches with 'web' or 'qemu-web' in the
> [...]  part of the subject ?

+1

... and Paolo, could you maybe fix up that line when picking up the patch?

 Thanks,
  Thomas